fix(html): add html reporter to rockspec #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tieske
approved these changes
Sep 7, 2023
Tieske
changed the title
|
Thank you, @Tieske, for the merge! I can see you removed the mention that the HTML Reporter depends on datafile. Should we consider as a good practice to change the local datafile_available, datafile = pcall(require, 'datafile')
if not datafile_available then
-- print a message to inforn the user they need to install datafile, then exit the program
end |
|
@Aire-One you're right, it is omitted. My intent was to add it to the rockspec as a dependency, but I see that I missed that. |
|
see #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
Following my message in #98, here are the necessary changes to make the Html reporter work with the Luarocks package.
It adds a new optional dependency on datafile. Because it's optional (only required by the Html reporter), I haven't pushed it to the rockspec's
dependenciestable.Alternatively, we could have included the file's content as long strings in the
reporter.html.*module. Since the static files are larges, I think it's better to manage them as regular files in the repository and access them withdatafile.Fixes #98